ER-040 Avoid equality operations on 'true' and 'false' boolean literals.

Severity2
Enabledyes
Waivable
Violation
if (strToCheck.equalsIgnoreCase(TXT1) == true) {
	return RETVAL1;
} else if (strToCheck.equalsIgnoreCase(TXT2) == false) {
	return RETVAL2;
} else {
	return RETVAL3;
}
Fix
if (strToCheck.equalsIgnoreCase(TXT1)) {
	return RETVAL1;
} else if (strToCheck.equalsIgnoreCase(TXT2)) {
	return RETVAL2;
} else {
	return RETVAL3;
}


Hammurapi 3 Copyright © 2004 Hammurapi Group. All Rights Reserved.