ER-056 Declare 'ejbCreate ()' methods "public", but neither "static" nor "final"

Severity1
Enabledyes
Waivable
Violation
Integer ejbCreate() throws CreateException, RemoteException {
	this.mProdSubmissionID = new Integer(0);
	return this.mProdSubmissionID;
}
public void ejbPostCreate() {
}
static Integer ejbCreate(final int pProdSubmissionID) throws CreateException, RemoteException {
	return new Integer(pProdSubmissionID);
}
public void ejbPostCreate(final int pProdSubmissionID) {
}
public final Integer ejbCreate(final Integer pProdSubmissionID) throws CreateException, RemoteException {
	this.mProdSubmissionID = pProdSubmissionID;
	return this.mProdSubmissionID;
}
public void ejbPostCreate(final Integer pProdSubmissionID) {
}
Fix
public Integer ejbCreate() throws CreateException, RemoteException {
	this.mProdSubmissionID = new Integer(0);
	return this.mProdSubmissionID;
}
public void ejbPostCreate() {
}
public Integer ejbCreate(final int pProdSubmissionID) throws CreateException, RemoteException {
	return new Integer(pProdSubmissionID);
}
public void ejbPostCreate(final int pProdSubmissionID) {
}
public Integer ejbCreate(final Integer pProdSubmissionID) throws CreateException, RemoteException {
	this.mProdSubmissionID = pProdSubmissionID;
	return this.mProdSubmissionID;
}
public void ejbPostCreate(final Integer pProdSubmissionID) {
}


Hammurapi 3 Copyright © 2004 Hammurapi Group. All Rights Reserved.