| Severity | 2 |
| Enabled | yes |
| Waivable | |
| Configuration |
Allowed logger class:
logger-class-name: org.apache.log4j.Logger
|
| Rationale | Logger shall be private because only declaring class shall use it.
Logger shall be static because it doesn't access any instance variables/methods.
Logger should be final as it should not change. Typical logger declaration: private static final Logger logger=Logger.getInstance(MyClass.class); |
| Violation |
public class DefineLoggerForClassRuleViolationTestCase {
private java.util.Date dateOfBegin = null;
public static final int MAX_RETR = 1;
}
|
| Fix |
public class DefineLoggerForClassRuleFixTestCase {
private static final org.apache.log4j.Logger logger = org.apache.log4j.Logger.getRootLogger();
private java.util.Date dateOfBegin = null;
public static final int MAX_RETR = 1;
}
|
| Resources | |