FileStorage.java
biz/hammurapi/legacy/persistence/FileStorage.java
Violations
Inspector |
Message |
Severity |
Location |
Java Inspector 048 |
Copyrights information should be present in each file. |
1 |
|
Java Inspector 089 |
Type is not documented |
2 |
37:1
|
Java Inspector 089 |
Undocumented constructor |
2 |
41:9
|
Java Inspector 089 |
Undocumented method |
2 |
45:9
|
Java Inspector 089 |
Undocumented method |
2 |
64:9
|
Java Inspector 089 |
Undocumented method |
2 |
80:9
|
Java Inspector 026 |
Avoid hardwired string literals. Allowed literals: [] |
3 |
48:63
|
Java Inspector 026 |
Avoid hardwired string literals. Allowed literals: [] |
3 |
48:74
|
Java Inspector 051 |
It is good practice to call in any case super() in a constructor. |
3 |
41:9
|
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23package biz.hammurapi.legacy.persistence;
24
25import java.io.File;
26import java.io.FileInputStream;
27import java.io.FileOutputStream;
28import java.io.IOException;
29import java.io.ObjectInputStream;
30import java.io.ObjectOutputStream;
31import java.io.Serializable;
32
33
34
35
36
37public class FileStorage implements Storage {
38
39 private File storageDir;
40
41 public FileStorage(File storageDir) {
42 this.storageDir=storageDir;
43 }
44
45 public String put(Object o) throws PersistenceException {
46 if (o instanceof Serializable) {
47 try {
48 File file=File.createTempFile("storage", ".dat", storageDir);
49 ObjectOutputStream oos=new ObjectOutputStream(new FileOutputStream(file));
50 try {
51 oos.writeObject(o);
52 } finally {
53 oos.close();
54 }
55 return file.getName();
56 } catch (IOException e) {
57 throw new PersistenceException(e);
58 }
59 } else {
60 return null;
61 }
62 }
63
64 public Object get(String key) throws PersistenceException {
65 File file=new File(storageDir, key);
66 try {
67 ObjectInputStream ois=new ObjectInputStream(new FileInputStream(file));
68 try {
69 return ois.readObject();
70 } finally {
71 ois.close();
72 }
73 } catch (IOException e) {
74 throw new PersistenceException(e);
75 } catch (ClassNotFoundException e) {
76 throw new PersistenceException(e);
77 }
78 }
79
80 public void remove(String key) throws PersistenceException {
81 new File(storageDir, key).delete();
82 }
83
84}
85